woem.men/forkey
4
2
Fork 3
Code Issues 34 Pull requests 16 Projects Releases Packages Wiki Activity Actions

frontend performance improvements #59

Merged
sugar merged 2 commits from sugar/forkey:frontend-performance-improvements into main 2025-02-07 18:36:40 +00:00
Conversation 0 Commits 2 Files changed 2 +45 -13
sugar commented 2025-02-02 16:36:23 +00:00
Owner
Copy link

What

makes phones less hot when using forkey compared to regular misskey by avoiding asking for animation frames when they are unnecessary

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests
<!-- ℹ お読みください / README PRありがとうございます！ PRを作成する前に、コントリビューションガイドをご確認ください: Thank you for your PR! Before creating a PR, please check the contribution guide: https://github.com/misskey-dev/misskey/blob/develop/CONTRIBUTING.md --> ## What <!-- このPRで何をしたのか？ どう変わるのか？ --> <!-- What did you do with this PR? How will it change things? --> makes phones less hot when using forkey compared to regular misskey by avoiding asking for animation frames when they are unnecessary ## Why <!-- なぜそうするのか？ どういう意図なのか？ 何が困っているのか？ --> <!-- Why do you do it? What are your intentions? What is the problem? --> ## Additional info (optional) <!-- テスト観点など --> <!-- Test perspective, etc --> ## Checklist - [ ] Read the [contribution guide](https://github.com/misskey-dev/misskey/blob/develop/CONTRIBUTING.md) - [ ] Test working in a local environment - [ ] (If needed) Add story of storybook - [ ] (If needed) Update CHANGELOG.md - [ ] (If possible) Add tests
sugar added 2 commits 2025-02-02 16:36:24 +00:00 
running animation handler every frame is slow
avoid computing tooltip position every frame
All checks were successful
Lint / pnpm_install (pull_request) Successful in 2m59s
Details
Test (frontend) / vitest (22.x) (pull_request) Successful in 2m56s
Details
Test (production install and build) / production (22.x) (pull_request) Successful in 2m16s
Details
Lint / lint (backend) (pull_request) Successful in 2m26s
Details
Lint / lint (frontend) (pull_request) Successful in 9m0s
Details
Lint / lint (misskey-js) (pull_request) Successful in 1m59s
Details
Lint / lint (sw) (pull_request) Successful in 2m13s
Details
Lint / typecheck (backend) (pull_request) Successful in 2m41s
Details
Lint / typecheck (misskey-js) (pull_request) Successful in 1m57s
Details
71606c5507 
this fixes an issue causing misskey to constantly recompute tooltip
position when any kind of chart is being displayed (such as the one
on user profile page, or any page for unauthenticated users)
sugar changed title from frontend-performance-improvements to Frontend performance improvements 2025-02-02 16:36:34 +00:00
sugar changed title from Frontend performance improvements to frontend performance improvements 2025-02-02 16:38:34 +00:00
leah approved these changes 2025-02-03 15:18:55 +00:00
sugar merged commit cfba325ae7 into main 2025-02-07 18:36:40 +00:00
sugar deleted branch frontend-performance-improvements 2025-02-07 18:36:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
leah
Labels
Clear labels   
bug

Something is not working

  
customization

Change something to be more suitable for forkey

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature parity

Another fork has this feature, and it should be pulled into this fork.

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
low priority

   
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
customization
duplicate
enhancement
feature parity
help wanted
high priority
invalid
low priority
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: woem.men/forkey#59
No description provided.
Delete branch "sugar/forkey:frontend-performance-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?