woem.men/forkey
4
2
Fork 3
Code Issues 34 Pull requests 16 Projects Releases Packages Wiki Activity Actions

Alt-text Novice Achivement #55

Open
leah wants to merge 2 commits from feature/alt-text-achivements into main
pull from: feature/alt-text-achivements
merge into: woem.men:main
Conversation 2 Commits 2 Files changed 7 +34 -3
leah commented 2025-01-19 22:52:56 +00:00
Owner
Copy link

Adds alt text novice Achivement
image

This is gotten when you have the alt text reminders on and post a post that has at least 1 attachment with alt text on it.

#37

Adds alt text novice Achivement ![image](/attachments/305d5bd5-f6c1-4e28-8c4c-fef2a1854513) This is gotten when you have the alt text reminders on and post a post that has at least 1 attachment with alt text on it. #37
image.png
25 KiB
leah added 2 commits 2025-01-19 22:52:56 +00:00
fix bug where posting with no text can get achievement
All checks were successful
Lint / pnpm_install (pull_request) Successful in 2m8s
Details
Test (backend) / unit (22.x) (pull_request) Successful in 10m4s
Details
Test (production install and build) / production (22.x) (pull_request) Successful in 2m42s
Details
Test (frontend) / vitest (22.x) (pull_request) Successful in 4m39s
Details
Test (backend) / validate-api-json (22.x) (pull_request) Successful in 3m25s
Details
Lint / lint (backend) (pull_request) Successful in 4m43s
Details
Lint / lint (frontend) (pull_request) Successful in 10m42s
Details
Lint / lint (misskey-js) (pull_request) Successful in 4m21s
Details
Lint / lint (sw) (pull_request) Successful in 3m11s
Details
Lint / typecheck (backend) (pull_request) Successful in 4m11s
Details
Lint / typecheck (misskey-js) (pull_request) Successful in 2m58s
Details
Test (backend) / e2e (22.x) (pull_request) Successful in 7m0s
Details
ff681a8e91
leah commented 2025-01-19 22:53:55 +00:00
Author
Owner
Copy link

Id love to add more things like "alt text 20 things to unlock" but that sounds like a lot more db queries and stuff and I dont want to slow down everything for an achievement

Id love to add more things like "alt text 20 things to unlock" but that sounds like a lot more db queries and stuff and I dont want to slow down everything for an achievement
leah commented 2025-02-08 02:01:40 +00:00
Author
Owner
Copy link

An easy solution to the more rare alt text badge is just have it be a low chance of unlocking when setting alt text. Thats super easy to add

An easy solution to the more rare alt text badge is just have it be a low chance of unlocking when setting alt text. Thats super easy to add
All checks were successful
Lint / pnpm_install (pull_request) Successful in 2m8s
Details
Test (backend) / unit (22.x) (pull_request) Successful in 10m4s
Details
Test (production install and build) / production (22.x) (pull_request) Successful in 2m42s
Details
Test (frontend) / vitest (22.x) (pull_request) Successful in 4m39s
Details
Test (backend) / validate-api-json (22.x) (pull_request) Successful in 3m25s
Details
Lint / lint (backend) (pull_request) Successful in 4m43s
Details
Lint / lint (frontend) (pull_request) Successful in 10m42s
Details
Lint / lint (misskey-js) (pull_request) Successful in 4m21s
Details
Lint / lint (sw) (pull_request) Successful in 3m11s
Details
Lint / typecheck (backend) (pull_request) Successful in 4m11s
Details
Lint / typecheck (misskey-js) (pull_request) Successful in 2m58s
Details
Test (backend) / e2e (22.x) (pull_request) Successful in 7m0s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/alt-text-achivements:feature/alt-text-achivements
git checkout feature/alt-text-achivements

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff feature/alt-text-achivements
git checkout feature/alt-text-achivements
git rebase main
git checkout main
git merge --ff-only feature/alt-text-achivements
git checkout feature/alt-text-achivements
git rebase main
git checkout main
git merge --no-ff feature/alt-text-achivements
git checkout main
git merge --squash feature/alt-text-achivements
git checkout main
git merge --ff-only feature/alt-text-achivements
git checkout main
git merge feature/alt-text-achivements
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
customization

Change something to be more suitable for forkey

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature parity

Another fork has this feature, and it should be pulled into this fork.

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
low priority

   
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
customization
duplicate
enhancement
feature parity
help wanted
high priority
invalid
low priority
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: woem.men/forkey#55
No description provided.
Delete branch "feature/alt-text-achivements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?