Custom Email Templates #45

Open

leah wants to merge 9 commits from feature/custom-email-template into main

pull from: feature/custom-email-template

merge into: woem.men:main

woem.men:main

woem.men:fix/add-missing-translations

woem.men:feature/mark-incoming-cwed-post-media-as-sensitive

woem.men:mute-fix

woem.men:cherrypick/small-and-center

woem.men:feature/post-languages

woem.men:cherrypick/refresh-polls

woem.men:cherrypick/listenbrainz

woem.men:feature/alt-text-achivements

woem.men:cherrypick/choosable-search-engine

woem.men:feature/indicate-block-mute

woem.men:cherrypick/wildcard-antenna-accts

woem.men:fix/scroll-alt-text

woem.men:feature/alt-text-badge

woem.men:feature/friendly-captcha

woem.men:forkey-rebrand

woem.men:bug/workflows

woem.men:feature/approval

woem.men:feature/meta-mfm

woem.men:feature/note-editing

Conversation 6 Commits 9 Files changed 12 +224 -81

leah commented 2025-01-19 14:51:29 +00:00

Owner

Copy link

Adds the ability to specify a custom email template using handlebars syntax.

#42

  Adds the ability to specify a custom email template using handlebars syntax. #42

image.png

25 KiB

image.png

98 KiB

leah added 2 commits 2025-01-19 14:51:29 +00:00

add ability to customize email template 287306a475

remove comments in template cc7def7593

leah added 1 commit 2025-01-19 14:54:13 +00:00

fix grammar 139341d866

itssophie commented 2025-01-19 15:07:32 +00:00

First-time contributor

Copy link

Is there a plaintext fallback?

Is there a plaintext fallback?

leah changed title from Custom Email Teplates to Custom Email Templates 2025-01-19 16:54:05 +00:00

leah commented 2025-01-19 17:01:24 +00:00

Author

Owner

Copy link

Is there a plaintext fallback?

Im not sure what you mean. If none is specified it will use a default which is close to what misskey has as the default. When you first edit this field it will be filled with the default config so you have a good base to start with.

Uhh also its handlebars so you technically can write it in plaintext but you wont get any style and it will probably smash it all on one line. If you want to strip the style though you can do that but I dont suggest using plaintext.

If you do plaintext like so:

{{ subject }}

{{ html }}

{{ emailSettingUrl }}

it looks like

in short it technically works to some extent but is also not the purpose of this. Its meant for allowing you to customize the style of your email.

> Is there a plaintext fallback? Im not sure what you mean. If none is specified it will use a default which is close to what misskey has as the default. When you first edit this field it will be filled with the default config so you have a good base to start with. Uhh also its handlebars so you technically can write it in plaintext but you wont get any style and it will probably smash it all on one line. If you want to strip the style though you can do that but I dont suggest using plaintext. If you do plaintext like so: ``` {{ subject }} {{ html }} {{ emailSettingUrl }} ``` it looks like  in short it technically works to some extent but is also not the purpose of this. Its meant for allowing you to customize the style of your email.

image.png

30 KiB

leah added 1 commit 2025-01-19 17:16:26 +00:00

added canIEmail help so people can check if the elements used are email supported 6d3c66f8c1

leah added 1 commit 2025-01-19 17:17:05 +00:00

remove commented code b8a938ace8

itssophie commented 2025-01-19 17:41:50 +00:00

First-time contributor

Copy link

Sorry, I maybe needed to say it better
Does it also send a plaintext fallback in the email, or does it only send the html? Like if my email client doesn't support html, or for accessibility/privacy reasons I have html disabled in the client, do I still get something to see, or is it just empty?

Sorry, I maybe needed to say it better Does it also send a plaintext fallback in the email, or does it only send the html? Like if my email client doesn't support html, or for accessibility/privacy reasons I have html disabled in the client, do I still get something to see, or is it just empty?

leah commented 2025-02-03 14:38:29 +00:00

Author

Owner

Copy link

Sorry, I maybe needed to say it better
Does it also send a plaintext fallback in the email, or does it only send the html? Like if my email client doesn't support html, or for accessibility/privacy reasons I have html disabled in the client, do I still get something to see, or is it just empty?

usually those providers will strip the content of the HTML and make it plaintext so I assume it should be fine?

> Sorry, I maybe needed to say it better > Does it also send a plaintext fallback in the email, or does it only send the html? Like if my email client doesn't support html, or for accessibility/privacy reasons I have html disabled in the client, do I still get something to see, or is it just empty? > usually those providers will strip the content of the HTML and make it plaintext so I assume it should be fine?

leah added 1 commit 2025-02-03 15:09:20 +00:00

fix linter issues 1090365cc0

leah added 1 commit 2025-02-04 17:08:25 +00:00

fix missing thing edaf9170dd

ashten added 1 commit 2025-02-05 04:31:29 +00:00

Merge branch 'main' into feature/custom-email-template d08b97f7d6

ashten added 1 commit 2025-02-05 04:40:49 +00:00

Merge branch 'main' into feature/custom-email-template e2cc20d4bc

ashten commented 2025-02-05 05:45:31 +00:00

Owner

Copy link

im experiencing a blank screen when i test this branch 😢

im experiencing a blank screen when i test this branch 😢 

image.png

26 KiB

leah commented 2025-02-05 12:12:11 +00:00

Author

Owner

Copy link

im experiencing a blank screen when i test this branch 😢

works on my machine... weird. Guess ill have a look with you on call later?

> im experiencing a blank screen when i test this branch 😢 > >  works on my machine... weird. Guess ill have a look with you on call later?

All checks were successful

Hide all checks

Lint / pnpm_install (pull_request) Successful in 37s

Details

API report (misskey.js) / report (push) Successful in 46s

Details

API report (misskey.js) / report (pull_request) Successful in 52s

Details

Test (misskey.js) / test (22.x) (pull_request) Successful in 49s

Details

Test (production install and build) / production (22.x) (pull_request) Successful in 1m4s

Details

Test (frontend) / vitest (22.x) (pull_request) Successful in 1m21s

Details

Test (backend) / unit (22.x) (pull_request) Successful in 2m34s

Details

Lint / lint (misskey-js) (pull_request) Successful in 36s

Details

Lint / lint (backend) (pull_request) Successful in 1m5s

Details

Test (backend) / validate-api-json (22.x) (pull_request) Successful in 1m29s

Details

Lint / lint (sw) (pull_request) Successful in 35s

Details

Lint / typecheck (misskey-js) (pull_request) Successful in 35s

Details

Lint / typecheck (backend) (pull_request) Successful in 1m26s

Details

Test (backend) / e2e (22.x) (pull_request) Successful in 6m34s

Details

Lint / lint (frontend) (pull_request) Successful in 7m23s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/custom-email-template:feature/custom-email-template

git checkout feature/custom-email-template

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff feature/custom-email-template

git checkout feature/custom-email-template

git rebase main

git checkout main

git merge --ff-only feature/custom-email-template

git checkout feature/custom-email-template

git rebase main

git checkout main

git merge --no-ff feature/custom-email-template

git checkout main

git merge --squash feature/custom-email-template

git checkout main

git merge --ff-only feature/custom-email-template

git checkout main

git merge feature/custom-email-template

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

customization

Change something to be more suitable for forkey

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

feature parity

Another fork has this feature, and it should be pulled into this fork.

  

help wanted

Need some help

  

high priority

  

invalid

Something is wrong

  

low priority

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

customization

duplicate

enhancement

feature parity

help wanted

high priority

invalid

low priority

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: woem.men/forkey#45

No description provided.