woem.men/forkey
4
2
Fork 3
Code Issues 34 Pull requests 16 Projects Releases Packages Wiki Activity Actions

dynamically load audio visualizer #39

Closed
sugar wants to merge 1 commit from sugar/forkey:dynamically-load-audio-visualizer into main
pull from: sugar/forkey:dynamically-load-audio-visualizer
merge into: woem.men:main
Conversation 1 Commits 1 Files changed 1 +2 -2
sugar commented 2025-01-17 13:39:09 +00:00
Owner
Copy link

audio visualizer weights 475 kB by itself, and audio files are relatively rare on timelines, so it makes sense to load it only when it's necessary

note that this change was submitted to upstream: https://github.com/MisskeyIO/misskey/pull/912

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests
audio visualizer weights 475 kB by itself, and audio files are relatively rare on timelines, so it makes sense to load it only when it's necessary note that this change was submitted to upstream: https://github.com/MisskeyIO/misskey/pull/912 <!-- ℹ お読みください / README PRありがとうございます！ PRを作成する前に、コントリビューションガイドをご確認ください: Thank you for your PR! Before creating a PR, please check the contribution guide: https://github.com/misskey-dev/misskey/blob/develop/CONTRIBUTING.md --> ## What <!-- このPRで何をしたのか？ どう変わるのか？ --> <!-- What did you do with this PR? How will it change things? --> ## Why <!-- なぜそうするのか？ どういう意図なのか？ 何が困っているのか？ --> <!-- Why do you do it? What are your intentions? What is the problem? --> ## Additional info (optional) <!-- テスト観点など --> <!-- Test perspective, etc --> ## Checklist - [ ] Read the [contribution guide](https://github.com/misskey-dev/misskey/blob/develop/CONTRIBUTING.md) - [ ] Test working in a local environment - [ ] (If needed) Add story of storybook - [ ] (If needed) Update CHANGELOG.md - [ ] (If possible) Add tests
sugar added 1 commit 2025-01-17 13:39:09 +00:00
dynamically load audio visualizer
All checks were successful
Test (production install and build) / production (22.x) (pull_request) Successful in 3m5s
Details
Lint / lint (frontend) (pull_request) Successful in 9m25s
Details
Lint / lint (misskey-js) (pull_request) Successful in 2m12s
Details
Lint / lint (sw) (pull_request) Successful in 2m30s
Details
Lint / typecheck (backend) (pull_request) Successful in 2m59s
Details
Lint / pnpm_install (pull_request) Successful in 2m15s
Details
Test (frontend) / vitest (22.x) (pull_request) Successful in 2m57s
Details
Lint / lint (backend) (pull_request) Successful in 2m56s
Details
Lint / typecheck (misskey-js) (pull_request) Successful in 2m31s
Details
a8f604137c 
audio visualizer weights 475 kB by itself, and audio files are
relatively rare on timelines, so it makes sense to load it only when
it's necessary
sugar commented 2025-01-17 14:21:26 +00:00
Author
Owner
Copy link

accepted by upstream, closing

accepted by upstream, closing
sugar closed this pull request 2025-01-17 14:21:26 +00:00
All checks were successful
Test (production install and build) / production (22.x) (pull_request) Successful in 3m5s
Details
Lint / lint (frontend) (pull_request) Successful in 9m25s
Details
Lint / lint (misskey-js) (pull_request) Successful in 2m12s
Details
Lint / lint (sw) (pull_request) Successful in 2m30s
Details
Lint / typecheck (backend) (pull_request) Successful in 2m59s
Details
Lint / pnpm_install (pull_request) Successful in 2m15s
Details
Test (frontend) / vitest (22.x) (pull_request) Successful in 2m57s
Details
Lint / lint (backend) (pull_request) Successful in 2m56s
Details
Lint / typecheck (misskey-js) (pull_request) Successful in 2m31s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
customization

Change something to be more suitable for forkey

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature parity

Another fork has this feature, and it should be pulled into this fork.

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
low priority

   
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
customization
duplicate
enhancement
feature parity
help wanted
high priority
invalid
low priority
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: woem.men/forkey#39
No description provided.
Delete branch "sugar/forkey:dynamically-load-audio-visualizer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?