woem.men/forkey
4
2
Fork 3
Code Issues 34 Pull requests 16 Projects Releases Packages Wiki Activity Actions

use uniform sampling in secure-rndstr #33

Merged
sugar merged 1 commit from sugar/forkey:use-uniform-sampling-in-secure-rndstr into main 2025-01-17 14:22:11 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -9
sugar commented 2025-01-12 10:34:12 +00:00
Owner
Copy link

the current implementation is biased towards making some characters 25% more common, with the default alphabet the more common characters being '0', '8', 'h', 'q', 'z', 'I', 'R', and 'Z' (see https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle#Modulo_bias)

this changes the probability of all letters to be equal

the current implementation is biased towards making some characters 25% more common, with the default alphabet the more common characters being '0', '8', 'h', 'q', 'z', 'I', 'R', and 'Z' (see https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle#Modulo_bias) this changes the probability of all letters to be equal
leah approved these changes 2025-01-14 13:15:24 +00:00
sugar force-pushed use-uniform-sampling-in-secure-rndstr from 7abd68de48 to 04b82b5373 2025-01-16 16:45:10 +00:00 Compare
sugar force-pushed use-uniform-sampling-in-secure-rndstr from 04b82b5373 to e6872e4f3b 2025-01-17 11:42:52 +00:00 Compare
sugar merged commit 7c3eb990a6 into main 2025-01-17 14:22:11 +00:00
sugar deleted branch use-uniform-sampling-in-secure-rndstr 2025-01-17 14:22:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
leah
Labels
Clear labels   
bug

Something is not working

  
customization

Change something to be more suitable for forkey

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature parity

Another fork has this feature, and it should be pulled into this fork.

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
low priority

   
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
customization
duplicate
enhancement
feature parity
help wanted
high priority
invalid
low priority
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: woem.men/forkey#33
No description provided.
Delete branch "sugar/forkey:use-uniform-sampling-in-secure-rndstr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?