use uniform sampling in secure-rndstr

the current implementation is biased towards making some characters
25% more common, with the default alphabet the more common characters
being '0', '8', 'h', 'q', 'z', 'I', 'R', and 'Z'

this changes the probability of all letters to be equal

packages/backend/src/misc/secure-rndstr.ts

@@ -9,17 +9,9 @@ export const L_CHARS = '0123456789abcdefghijklmnopqrstuvwxyz';
 const LU_CHARS = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
 
 export function secureRndstr(length = 32, { chars = LU_CHARS } = {}): string {
-	const chars_len = chars.length;
-
 	let str = '';
-
 	for (let i = 0; i < length; i++) {
-		let rand = Math.floor((crypto.randomBytes(1).readUInt8(0) / 0xFF) * chars_len);
+		str += chars.charAt(crypto.randomInt(chars.length));
-		if (rand === chars_len) {
-			rand = chars_len - 1;
-		}
-		str += chars.charAt(rand);
 	}
-
 	return str;
 }