woem.men/forkey
4
2
Fork 3
Code Issues 34 Pull requests 16 Projects Releases Packages Wiki Activity Actions

avoid computing tooltip position every frame
All checks were successful
Lint / pnpm_install (pull_request) Successful in 2m59s
Details
Test (frontend) / vitest (22.x) (pull_request) Successful in 2m56s
Details
Test (production install and build) / production (22.x) (pull_request) Successful in 2m16s
Details
Lint / lint (backend) (pull_request) Successful in 2m26s
Details
Lint / lint (frontend) (pull_request) Successful in 9m0s
Details
Lint / lint (misskey-js) (pull_request) Successful in 1m59s
Details
Lint / lint (sw) (pull_request) Successful in 2m13s
Details
Lint / typecheck (backend) (pull_request) Successful in 2m41s
Details
Lint / typecheck (misskey-js) (pull_request) Successful in 1m57s
Details

Browse source 
this fixes an issue causing misskey to constantly recompute tooltip
position when any kind of chart is being displayed (such as the one
on user profile page, or any page for unauthenticated users)
This commit is contained in:
sugar 2025-02-02 17:33:33 +01:00
parent 8165088886
commit 71606c5507
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/frontend/src/components/MkTooltip.vue
View file

@ -23,7 +23,7 @@ SPDX-License-Identifier: AGPL-3.0-only
</template> </template>
<script lang="ts" setup> <script lang="ts" setup>
import { nextTick, onMounted, onUnmounted, shallowRef } from 'vue'; import { nextTick, onMounted, onUnmounted, shallowRef, watch } from 'vue';
import * as os from '@/os.js'; import * as os from '@/os.js';
import { calcPopupPosition } from '@/scripts/popup-position.js'; import { calcPopupPosition } from '@/scripts/popup-position.js';
import { defaultStore } from '@/store.js'; import { defaultStore } from '@/store.js';
@ -70,7 +70,7 @@ function setPosition() {
el.value.style.top = data.top + 'px'; el.value.style.top = data.top + 'px';
} }
let loopHandler; let loopHandler: number | undefined;
onMounted(() => { onMounted(() => {
nextTick(() => { nextTick(() => {
@ -81,12 +81,23 @@ onMounted(() => {
loopHandler = window.requestAnimationFrame(loop); loopHandler = window.requestAnimationFrame(loop);
}; };
loop(); watch(() => props.showing, show => {
if (show) {
if (!loopHandler) {
loop();
}
} else if (loopHandler) {
window.cancelAnimationFrame(loopHandler);
loopHandler = undefined;
}
});
}); });
}); });
onUnmounted(() => { onUnmounted(() => {
window.cancelAnimationFrame(loopHandler); if (loopHandler) {
window.cancelAnimationFrame(loopHandler);
}
}); });
</script> </script>